Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert change back #2071

Merged
1 commit merged into from
Oct 5, 2021
Merged

Revert change back #2071

1 commit merged into from
Oct 5, 2021

Conversation

seankane-msft
Copy link
Member

Reverts back to a version that does not have mysterious Credential Issue

Reverts back to a version that does not have mysterious Credential Issue
@seankane-msft seankane-msft self-assigned this Oct 5, 2021
@seankane-msft seankane-msft requested a review from a team as a code owner October 5, 2021 16:35
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for this one given that:

A) you're the only one currently using this thing in real pipelines
B) I have a PR in mind, but we want to just get you unblocked for release, and adding a new feature at release time is a bad plan.
C) I will submit a follow-up that allows override at the parameter level.

@ghost
Copy link

ghost commented Oct 5, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit c90f9ab into main Oct 5, 2021
@ghost ghost deleted the seankane-msft-patch-1 branch October 5, 2021 21:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants