Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip PSModule caching in container jobs #2009

Merged
2 commits merged into from
Sep 15, 2021

Conversation

benbp
Copy link
Member

@benbp benbp commented Sep 13, 2021

Containers should bake modules into the image to save on pipeline time.

@benbp benbp requested a review from a team as a code owner September 13, 2021 22:21
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Sep 13, 2021
@benbp benbp self-assigned this Sep 13, 2021
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be an OK workaround for now but I suspect it is going to cause other breaks where the images we use don't end up having a valid version of the modules we might be looking for. However I guess if folks are doing the right things it should just cause them to need to download them so it will mostly be a perf and reliability issue.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp
Copy link
Member Author

benbp commented Sep 13, 2021

I think this might be an OK workaround for now but I suspect it is going to cause other breaks where the images we use don't end up having a valid version of the modules we might be looking for. However I guess if folks are doing the right things it should just cause them to need to download them so it will mostly be a perf and reliability issue.

I think we should keep that problem scoped to an image management issue though, rather than as a workaround with environment setup. If we start using container images for testing more broadly, then these images should be testable locally. Right now our pipeline environment setup is not reproducible locally, but we have an opportunity to achieve this if we don't rely on yaml orchestrated setup for container testing. I don't think maintaining an az module version and related things across our image inventory is going to have to be very hands on.

@benbp
Copy link
Member Author

benbp commented Sep 15, 2021

/check-enforcer override

@ghost
Copy link

ghost commented Sep 15, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit d6469e4 into Azure:main Sep 15, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants