-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip PSModule caching in container jobs #2009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be an OK workaround for now but I suspect it is going to cause other breaks where the images we use don't end up having a valid version of the modules we might be looking for. However I guess if folks are doing the right things it should just cause them to need to download them so it will mostly be a perf and reliability issue.
The following pipelines have been queued for testing: |
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
I think we should keep that problem scoped to an image management issue though, rather than as a workaround with environment setup. If we start using container images for testing more broadly, then these images should be testable locally. Right now our pipeline environment setup is not reproducible locally, but we have an opportunity to achieve this if we don't rely on yaml orchestrated setup for container testing. I don't think maintaining an az module version and related things across our image inventory is going to have to be very hands on. |
/check-enforcer override |
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Containers should bake modules into the image to save on pipeline time.