Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ubuntu 20 to local dns bypass template #1736

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Add Ubuntu 20 to local dns bypass template #1736

merged 1 commit into from
Jun 24, 2021

Conversation

praveenkuttappan
Copy link
Member

Live test is failing on Ubuntu with local DNS error we have faced in the past on Ubuntu 1804 image. We are facing this issue again on Ubuntu 20.04 image. PR is to run bypass DNS step on Ubuntu 20.04 as well.

@praveenkuttappan praveenkuttappan requested a review from a team as a code owner June 24, 2021 17:10
@praveenkuttappan praveenkuttappan self-assigned this Jun 24, 2021
@praveenkuttappan praveenkuttappan added the Central-EngSys This issue is owned by the Engineering System team. label Jun 24, 2021
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Jun 24, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
weshaggard
weshaggard reviewed Jun 24, 2021
View reviewed changes
eng/common/pipelines/templates/steps/bypass-local-dns.yml
@@ -8,7 +8,9 @@ steps:
succeededOrFailed(),
or(
eq(variables['OSVmImage'], 'ubuntu-18.04'),
eq(variables['OSVmImage'], 'MMSUbuntu18.04')
eq(variables['OSVmImage'], 'ubuntu-20.04'),
Copy link
Member

@weshaggard weshaggard Jun 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get things unblocked as possible but it might be worth switching this to something like contains(variables['OSVmImage'], 'ubunutu') in a future follow-up.

https://docs.microsoft.com/en-us/azure/devops/pipelines/process/expressions?view=azure-devops#contains claims to be case insensitive but we would need to test.

@ghost
Copy link

ghost commented Jun 24, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@chidozieononiwu
Copy link
Member

chidozieononiwu commented Jun 24, 2021 •
edited
Loading

For some reason this was not merged.

@chidozieononiwu chidozieononiwu merged commit 1c889f5 into Azure:main Jun 24, 2021
@praveenkuttappan praveenkuttappan deleted the feature/add_ubuntu20_dnsbypass branch June 28, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@chidozieononiwu chidozieononiwu chidozieononiwu approved these changes

Assignees

@praveenkuttappan praveenkuttappan

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@praveenkuttappan @azure-sdk @chidozieononiwu @weshaggard