Update format of new Changelog Entry #1633
Conversation
|
The following pipelines have been queued for testing: |
chidozieononiwu
force-pushed
the
UpdateChangelogContentFormat
branch
from
640ffa6
to
bef1cc7
Compare
|
The following pipelines have been queued for testing: |
chidozieononiwu
force-pushed
the
UpdateChangelogContentFormat
branch
from
bef1cc7
to
9f63951
Compare
|
The following pipelines have been queued for testing: |
chidozieononiwu
force-pushed
the
UpdateChangelogContentFormat
branch
from
7cbb900
to
df94b47
Compare
|
The following pipelines have been queued for testing: |
| if ($line.Trim() -match "^###\s(?<sectionName>.*)") | ||
| { | ||
| $sectionName = $matches["sectionName"].Trim() | ||
| $changeLogEntry.Sections[$sectionName] = @() |
There was a problem hiding this comment.
If there are multiple sections with the same name this will essentially throw out the old section. That might not be a real issue but something to keep in mind.
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
/check-enforcer override |
ghost
merged commit
| @@ -195,7 +208,19 @@ function New-ChangeLogEntry { | |||
| return $null | |||
| } | |||
|
|
|||
| if (!$Content) { $Content = @() } | |||
| if (!$Content) { | |||
There was a problem hiding this comment.
@chidozieononiwu one other question that I just thought about is now our verify changelog check that validates that the change log isn't empty should be updated to verify that the change log entry doesn't have all empty sections.
Update changelog entry to match updated guidance https://azure.github.io/azure-sdk/policies_releases.html#change-logs
New Changelog entries will now look like