-
Notifications
You must be signed in to change notification settings - Fork 229
Add 'APIView prod deployment' to internal service connections #13334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds "APIView prod deployment" to the list of internal service connections in the pipeline preparation template. This ensures that the service connection, which is already used in the create-apireview step, is properly authorized for internal pipeline operations.
- Adds "APIView prod deployment" service connection to the
$internalServiceConnectionsvariable
|
@weshaggard out of curiosity, what does adding APIView to this script do? |
|
The following pipelines have been queued for testing: |
This script is used to setup our pipelines and currently we added this new APIView service connection usage to our internal pipelines, but they don't permissions to that. This will add it to the list of service connections we grant permissions to our pipeline. |
|
/azp run azure-sdk-tools - sync - eng-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13334 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13334 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
No description provided.