Skip to content

Add #Requires statement to common.ps1 #13305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hallipr merged 1 commit into from
Dec 10, 2025
Merged

Add #Requires statement to common.ps1 #13305

hallipr merged 1 commit into from
Dec 10, 2025

Conversation

@hallipr
Copy link
Member

@hallipr hallipr commented Dec 10, 2025

Setting baseline supported powershell version for most of eng/common to 7.0

@hallipr hallipr requested a review from a team as a code owner December 10, 2025 19:06
Copilot AI review requested due to automatic review settings December 10, 2025 19:06
Copilot AI reviewed Dec 10, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR establishes PowerShell 7.0 as the baseline requirement for the common engineering scripts by adding a #Requires statement to the common.ps1 file.

  • Adds version requirement directive to enforce PowerShell 7.0 or higher

@azure-sdk
Copy link
Collaborator

azure-sdk commented Dec 10, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Dec 10, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Dec 10, 2025
@azure-sdk @hallipr
Sync eng/common directory with azure-sdk-tools for PR 13305 (#36848)
97fadf1 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#13305 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
azure-sdk added a commit to Azure/azure-sdk-for-rust that referenced this pull request Dec 10, 2025
@azure-sdk @hallipr
Sync eng/common directory with azure-sdk-tools for PR 13305 (#3421)
25faa5e 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#13305 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
@hallipr hallipr merged commit 813e623 into main Dec 10, 2025
18 checks passed
@hallipr hallipr deleted the users/pahallis/requires branch December 10, 2025 21:43
JiaqiZhang-Dev pushed a commit that referenced this pull request Dec 22, 2025
@hallipr
Add #Requires statement to common.ps1 (#13305)
3e6670b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@weshaggard weshaggard weshaggard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hallipr @azure-sdk @weshaggard