Skip to content

Conversation

@hallipr
Copy link
Member

@hallipr hallipr commented Dec 5, 2025

The script call Invoke-LoggedMsBuildCommand $command -GroupOutput should log the command before logging its output.
When run locally, LogGroupStart logs nothing, so the command isn't logged.

Copilot AI review requested due to automatic review settings December 5, 2025 19:14
@hallipr hallipr requested a review from a team as a code owner December 5, 2025 19:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds local build output for the LogGroupStart function to ensure that commands are logged when running in local environments (outside of Azure DevOps or GitHub Actions). Previously, LogGroupStart would only produce output in CI/CD environments, making it difficult to see grouped command output during local development.

Key Changes

  • Added an else block to LogGroupStart that outputs the group message with a > prefix for local environments

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Dec 9, 2025
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#13222 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
azure-sdk added a commit to Azure/azure-sdk-for-rust that referenced this pull request Dec 9, 2025
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#13222 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
@hallipr hallipr merged commit bb3d6af into main Dec 9, 2025
18 checks passed
@hallipr hallipr deleted the users/pahallis/local-group-start branch December 9, 2025 07:50
hallipr added a commit to hallipr/microsoft-mcp that referenced this pull request Dec 9, 2025
hallipr added a commit to microsoft/mcp that referenced this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants