-
Notifications
You must be signed in to change notification settings - Fork 223
Add a dry run of package release cli command #13134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
tools/azsdk-cli/Azure.Sdk.Tools.Cli/Tools/Package/SdkReleaseTool.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR replaces the standalone azsdk pkg release-readiness command with a --dry-run option for the azsdk pkg release command, consolidating related functionality into a single command interface.
Key changes:
- Added a
--dry-runboolean option to the release command that performs readiness checks without triggering the release pipeline - Updated the
ReleasePackageAsyncmethod signature to accept an optionaldryRunparameter - Removed
ReleaseReadinessToolfrom theSharedOptionstool registry
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tools/azsdk-cli/Azure.Sdk.Tools.Cli/Tools/Package/SdkReleaseTool.cs | Added --dry-run option and corresponding logic to perform readiness checks without triggering the release pipeline |
| tools/azsdk-cli/Azure.Sdk.Tools.Cli/Commands/SharedOptions.cs | Removed ReleaseReadinessTool from the list of registered command tools |
tools/azsdk-cli/Azure.Sdk.Tools.Cli/Tools/Package/SdkReleaseTool.cs
Outdated
Show resolved
Hide resolved
tools/azsdk-cli/Azure.Sdk.Tools.Cli/Tools/Package/SdkReleaseTool.cs
Outdated
Show resolved
Hide resolved
tools/azsdk-cli/Azure.Sdk.Tools.Cli/Tools/Package/SdkReleaseTool.cs
Outdated
Show resolved
Hide resolved
…ol.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ure-sdk-tools into dry-run=package-release
tools/azsdk-cli/Azure.Sdk.Tools.Cli/Tools/Package/SdkReleaseTool.cs
Outdated
Show resolved
Hide resolved
tools/azsdk-cli/Azure.Sdk.Tools.Cli.Tests/Tools/SdkReleaseToolTests.cs
Outdated
Show resolved
Hide resolved
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
tools/azsdk-cli/Azure.Sdk.Tools.Cli/Tools/Package/SdkReleaseTool.cs
Outdated
Show resolved
Hide resolved
tools/azsdk-cli/Azure.Sdk.Tools.Cli/Tools/Package/SdkReleaseTool.cs
Outdated
Show resolved
Hide resolved
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
azsdk pkg release-readinessand replace it withazsdk pgk release --dry-run.