Update cache-control for newly created blobs #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 1, 2020
weshaggard
reviewed
Oct 1, 2020
| @@ -229,7 +229,7 @@ function Upload-Blobs | |||
| if ($UploadLatest -and ($latestVersion -eq $DocVersion)) | |||
| { | |||
| Write-Host "Uploading $($PkgName) to latest folder in $($DocDest)..." | |||
| & $($AzCopy) cp "$($DocDir)/**" "$($DocDest)/$($PkgName)/latest$($SASKey)" --recursive=true | |||
| & $($AzCopy) cp "$($DocDir)/**" "$($DocDest)/$($PkgName)/latest$($SASKey)" --recursive=true --cache-control "max-age=300, must-revalidate" | |||
There was a problem hiding this comment.
Don't we also want to add this to our versions file updated? Based on the issue I thought that was the file they were interested in making sure the cache expires.
There was a problem hiding this comment.
I have already updated the existing ones for temporary fix. I was thinking we might only need to fix newly created one. But after a second though, it still has the chance of overwriting the existing version doc. So I will update the rest places(new and existing ones).
mitchdenny
approved these changes
Oct 7, 2020
|
The following pipelines have been queued for testing: |
sima-zhu
pushed a commit
to sima-zhu/azure-sdk-tools
that referenced
this pull request
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the existing ones using azure powershell.
Update the script here to make sure we update the cache-control for newly created blobs.
Fixed issue: #976