Skip to content

[Breaking Change][PR Workflow] REST API Breaking Changes PR check should check who added the suppression label #6035

Open

Description

PRs in the azure-rest-api-specs repo are blocked from merging if the Breaking Changes PR check reports a failure. But the result of the Breaking Changes check is squashed if the "Approved-BreakingChange" label has been added to the PR. That label is supposed to signify that the PR was reviewed by the Breaking Change review board and determined to be an allowable change.

Unfortunately, there is no means to prevent any user with labelling permissions to add the "Approved-BreakingChange" label, so changes that should not be permitted are allowed to merge, resulting in customer disruption.

An example is PR 23647.

image

image

Since we cannot restrict who can add the label, I think the PR check must only be squashed if the label was added by a member of the breaking change review board or otherwise trained and responsible user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Labels

Breaking ChangesImprovements to Breaking Changes toolingCentral-EngSysThis issue is owned by the Engineering System team.Spec PR ToolsTooling that runs in azure-rest-api-specs repo.feature-requestThis issue requires a new behavior in the product in order be resolved.

Type

No type

Projects

  • Status

    📋 Backlog
  • Status

    📋 Backlog

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions