-
Notifications
You must be signed in to change notification settings - Fork 314
Permissions Module #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! I'm going to run the examples and the E2E tests and approve it.
@MindFlavor Sorry that I broke things! I'm going to make sure I'm running the e2e before submitting PRs from now on. |
@MindFlavor This should be good to go now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little typo in one test. Once fixed we can merge this!
Co-authored-by: Francesco Cogno <francesco.cogno@outlook.com>
This PR cleans the Cosmos permissions related code. This is preparation for eventually moving all Cosmos models (i.e., Permissions, Databases, Stored Procedures, etc.) into their own module.
Highlights of the changes here:
AuthorizationToken::Master
toAuthorizationToken::Primary
as the docs have begun to transition to this nomenclature.PermissionResource
as it wasn't really being used for much and made the code more complicatedTODO: I need to run the examples to ensure that the code still works 😄