Skip to content

Conversation

Alexei-B
Copy link

@Alexei-B Alexei-B commented Nov 22, 2020

PR to address #21

To complete the message lifecycle for Azure Storage Queue we need the ability to delete messages.
To enable this, I have made the Message struct public, and used it as the required parameter to the new DeleteMessageBuilder request's method with_message. This sets the messageid URL path parameter, as well as the popreceipt query parameter.
I have added an example to show how the API can be used.

@ghost
Copy link

ghost commented Nov 22, 2020

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@MindFlavor MindFlavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thank you!

I just have one suggestion to make the API cleaner but it's optional (we can add it a later time). Just tell me if you want me to merge this as it is and I'll do it.

Instead of using Message for delete, we now use the trait PopReceipt.
@Alexei-B
Copy link
Author

Nice work, thank you!

I just have one suggestion to make the API cleaner but it's optional (we can add it a later time). Just tell me if you want me to merge this as it is and I'll do it.

I'm ready for this to be merged, happy to add the protection against calling execute without a pop receipt if you don't beat me to it.

@MindFlavor
Copy link
Contributor

I'm ready for this to be merged, happy to add the protection against calling execute without a pop receipt if you don't beat me to it.

Ok as soon as the checks complete I'll merge it and open the issue for the compile-time checks.
If you are up to it I'll leave you to implement it (it's your code after all, you deserve all the credit 👍!)

@MindFlavor MindFlavor merged commit 89a496c into Azure:master Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants