add azure-autorust bin #896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmc-msft
reviewed
Jul 5, 2022
Comment on lines
+86
to
+104
| fn gen_workflow_publish_sdks() -> Result<()> { | ||
| let packages = &vec![ | ||
| "azure_core", | ||
| "azure_data_cosmos", | ||
| "azure_data_tables", | ||
| "azure_identity", | ||
| "azure_iot_hub", | ||
| "azure_messaging_eventgrid", | ||
| "azure_messaging_servicebus", | ||
| "azure_security_keyvault", | ||
| "azure_storage", | ||
| "azure_storage_blobs", | ||
| "azure_storage_datalake", | ||
| "azure_storage_queues", | ||
| ]; | ||
| let yml = PublishSdksYml { packages }; | ||
| yml.create("../../.github/workflows/publish-sdks.yml")?; | ||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
It feels weird that configs for the SDK crates are written by azure-autorust.
There was a problem hiding this comment.
I agree. It is behind a --publish arg and I'm the only one who runs it. It would be nice to keep the creation of the workflows together. It just saves me time. I can move this back into an example if you would prefer that.
bmc-msft
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates the scripts used to do the code generation into an executable. It is a direct port. This will open up the door for adding additional args.