Use Response::is_success for retry policy
#890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cataggar
reviewed
Jul 4, 2022
| loop { | ||
| let error = match next[0].send(ctx, request, &next[1..]).await { | ||
| Ok(response) if (200..400).contains(&u16::from(response.status())) => { | ||
| Ok(response) if response.status().is_success() => { |
There was a problem hiding this comment.
A concern is that it is a change in behavior. What if it .is_redirection in the 300..400 range?
There was a problem hiding this comment.
We should have a policy with regards to redirection and it should occur before retry, but it should not be intermingled with retry.
bmc-msft
approved these changes
Jul 5, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #836