Break up sdk and services into two workspaces #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
force-pushed
the
two-workspaces
branch
from
e5e8091 to
ddfc412
Compare
guywaldman
reviewed
Nov 19, 2020
.github/workflows/build.yml
Outdated
| - name: tests | ||
| run: | | ||
| cargo test --all | ||
| cargo build --manifest-path services/Cargo.toml --all |
There was a problem hiding this comment.
Maybe build as a different stage?
There was a problem hiding this comment.
I think that's a good idea. 👍
MindFlavor
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can reduce the amount of time local building takes rather considerably.