More headers cleanup #864
Merged
More headers cleanup #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
force-pushed
the
final-headers-cleanup
branch
from
e28cc0d to
307aed4
Compare
ctaggart
approved these changes
Jun 28, 2022
| }) | ||
| }) | ||
| .transpose() | ||
| headers.get_optional_as(&CONTENT_CRC64) |
cataggar
approved these changes
Jun 28, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some last changes to how we handle headers:
get_optional_$typeandget_$typeFromStrimpls for more types so thatget_asandget_optional_asjust work.