Skip to content

Fixed adls_gen2 E2E test #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2020
Merged

Fixed adls_gen2 E2E test #86

merged 1 commit into from
Nov 18, 2020

Conversation

MindFlavor
Copy link
Contributor

Solves #85.

rylev
rylev approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, but I didn't run the test. I assume this fixes the issue?

@MindFlavor
Copy link
Contributor Author

Yes, it just ignores the preexisting storage containers (the previous code failed in case there were other blob storage containers in the same account).

@MindFlavor MindFlavor merged commit c4c1456 into master Nov 18, 2020
@MindFlavor MindFlavor deleted the issue/85 branch December 11, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rylev rylev rylev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MindFlavor @rylev