Skip to content

header name constants changed from &str to HeaderName #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 22, 2022
Merged

header name constants changed from &str to HeaderName #839

merged 12 commits into from
Jun 22, 2022

Conversation

ctaggart
Copy link
Contributor

@ctaggart ctaggart commented Jun 21, 2022 •
edited by cataggar
Loading

  • header name constants changed from &str to azure_core::headers::HeaderName
  • replaced types from http:header with azure_core::headers types
  • create const fn HeaderName::from_static
  • Header::get takes a &HeaderName instead of Into<HeaderName>
  • similar changes for HeaderValue
  • removed Request::headers_mut

@ctaggart ctaggart mentioned this pull request Jun 21, 2022
Merged
@cataggar cataggar changed the title const HeaderName::from_static replaced types from http:header with azure_core::headers types Jun 22, 2022
@cataggar cataggar changed the title replaced types from http:header with azure_core::headers types header name constants changed from &str to HeaderName Jun 22, 2022
@cataggar cataggar marked this pull request as ready for review June 22, 2022 20:15
cataggar
cataggar reviewed Jun 22, 2022
View reviewed changes
cataggar
cataggar reviewed Jun 22, 2022
View reviewed changes
cataggar
cataggar reviewed Jun 22, 2022
View reviewed changes
cataggar
cataggar reviewed Jun 22, 2022
View reviewed changes
@cataggar cataggar requested review from bmc-msft and rylev June 22, 2022 21:28
@cataggar cataggar merged commit 58806e4 into Azure:main Jun 22, 2022
@ctaggart ctaggart deleted the static_headers branch August 2, 2022 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cataggar cataggar cataggar left review comments

@rylev rylev Awaiting requested review from rylev

+1 more reviewer

@bmc-msft bmc-msft bmc-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ctaggart @bmc-msft @cataggar