Support getting and setting the module/device twin for Azure IoT Hub Service #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MindFlavor
reviewed
Nov 16, 2020
MindFlavor
approved these changes
Nov 16, 2020
rylev
reviewed
Nov 16, 2020
rylev
suggested changes
Nov 16, 2020
corollaries
force-pushed
the
feature/corollaries/implement-twin
branch
from
38a9e29 to
b214734
Compare
corollaries
force-pushed
the
feature/corollaries/implement-twin
branch
from
b214734 to
3715842
Compare
rylev
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for most twin related operations for the IoT Hub Service SDK.
Added
get_module_twin,get_device_twin,update_module_twin,replace_module_twin,update_device_twin,replace_device_twinfunctions toiothub::ServiceClient.Discussion
DesiredTwinBuildergeneric so it can be used for both updating module and device twins. As to hide some details for the user (mainly the return type ofexecutewhich returns theModuleTwinwhen updating modules andDeviceTwinfor updating the devices) I had to resort to usingstd::marker::PhantomDatain theDesiredTwinBuilder. I'm not too sure about that in particular, but couldn't find another way of doing this neatly.