Skip to content

Migrate storage to new azure_core::error scheme #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 14, 2022
Merged

Migrate storage to new azure_core::error scheme #792

merged 3 commits into from
Jun 14, 2022

Conversation

johnbatty
Copy link
Contributor

Part of the mission to migrate crates to the new error scheme:
#771

@cataggar cataggar mentioned this pull request Jun 10, 2022
Closed
12 tasks
@roeap roeap mentioned this pull request Jun 10, 2022
Merged
@johnbatty
Copy link
Contributor Author

I've believe I've made all the necessary changes to storage, and the crate itself builds. However the changes cause the other storage crates to fail to build because they have a dependency on storage, and in particular they expect old-style error types. Therefore we need to push on and get all of the storage crate family migrated, at which point this should build/pass the CI tests.

@rickrain rickrain mentioned this pull request Jun 13, 2022
Merged
@johnbatty johnbatty force-pushed the storage-error-migrate branch from 6e7bc8a to b4d4949 Compare June 14, 2022 19:46
@johnbatty johnbatty force-pushed the storage-error-migrate branch from b4d4949 to 7cf16de Compare June 14, 2022 20:25
@johnbatty johnbatty changed the title WIP: Migrate storage to new azure_core::error scheme Migrate storage to new azure_core::error scheme Jun 14, 2022
@johnbatty johnbatty requested a review from cataggar June 14, 2022 21:03
@johnbatty
Copy link
Contributor Author

Ok, now builds with the latest storage crates. Had to tweak storage_blobs to fix up a couple of API calls to match the new API.

@cataggar cataggar merged commit e912f56 into Azure:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cataggar cataggar cataggar approved these changes

+1 more reviewer

@ctaggart ctaggart ctaggart approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johnbatty @ctaggart @cataggar