Skip to content

Export credentials from azure_identity #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 20, 2022
Merged

Export credentials from azure_identity #756

merged 6 commits into from
May 20, 2022

Conversation

heaths
Copy link
Member

@heaths heaths commented May 19, 2022

Bring the azure_identity crate more in line with most other languages' Identity packages.

@heaths
Export credentials from azure_identity
a1bad6e 
Bring the azure_identity crate more in line with most other languages' Identity packages.
rylev
rylev reviewed May 19, 2022
View reviewed changes
Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, but I'll defer to @ctaggart and @bmc-msft

cataggar
cataggar approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@cataggar cataggar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I just prepared a 0.3.0 release. To include this change, please merge in main and update the changelog.

bmc-msft
bmc-msft approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@bmc-msft bmc-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cataggar cataggar merged commit df7d7fa into Azure:main May 20, 2022
@heaths heaths deleted the refactor_identity branch May 23, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cataggar cataggar cataggar approved these changes

+2 more reviewers

@rylev rylev rylev left review comments

@bmc-msft bmc-msft bmc-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@heaths @rylev @bmc-msft @cataggar @ctaggart