Skip to content

Conversation

sd2k
Copy link
Contributor

@sd2k sd2k commented Nov 8, 2020

This PR adds the get_blob_properties method to Blob.

It also changes the test_e2e feature to require other features (since otherwise the adls2_gen2 feature was missing and e2e tests would not compile).

I wasn't completely sure whether the request builder JSON was autogenerated or required for something - is there some documentation about those files somewhere?

Closes #72.

@ghost
Copy link

ghost commented Nov 8, 2020

CLA assistant check
All CLA requirements met.

@sd2k sd2k changed the title Add get_blob_properties method to Blob (#72) Add get_blob_properties method to Blob Nov 8, 2020
Also add other features to test_e2e features list, since the E2E tests
should require everything else (in particular adls_gen2).
@sd2k sd2k force-pushed the add-get-blob-properties branch from a4d9831 to 077885d Compare November 8, 2020 13:20
Copy link
Contributor

@MindFlavor MindFlavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks! 👍

@MindFlavor
Copy link
Contributor

I wasn't completely sure whether the request builder JSON was autogenerated or required for something - is there some documentation about those files somewhere?

It's used to scaffold its relative rs file (the scaffolding tool is bpb but that's about to change). It's not mandatory but it's nice to have for further enhancements.

@MindFlavor MindFlavor merged commit bec3ed3 into Azure:master Nov 8, 2020
@sd2k sd2k deleted the add-get-blob-properties branch November 8, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Azure Storage blob - Get Blob Properties method

2 participants