allow setting the authority_host with TokenCredentialOptions #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MindFlavor
suggested changes
Nov 8, 2020
sdk/identity/src/token_credentials/client_secret_credentials.rs
Outdated
Show resolved
Hide resolved
rylev
reviewed
Nov 9, 2020
There was a problem hiding this comment.
Mostly looks good, but I share some of the small concerns @MindFlavor has expressed.
sdk/identity/src/token_credentials/client_secret_credentials.rs
Outdated
Show resolved
Hide resolved
sdk/identity/src/token_credentials/client_secret_credentials.rs
Outdated
Show resolved
Hide resolved
|
Thanks for the feedback. I addressed the concerns in dce2d25. Please approve this & the other PR. |
rylev
reviewed
Nov 9, 2020
sdk/identity/src/token_credentials/client_secret_credentials.rs
Outdated
Show resolved
Hide resolved
rylev
reviewed
Nov 9, 2020
sdk/identity/src/token_credentials/client_secret_credentials.rs
Outdated
Show resolved
Hide resolved
rylev
reviewed
Nov 9, 2020
rylev
approved these changes
Nov 10, 2020
|
This is waiting on @MindFlavor's re-review. |
MindFlavor
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports support for setting an
authority_host, so another Azure Cloud instance can be used. I ported code from:links
https://devblogs.microsoft.com/azure-sdk/azure-identity-august-2020-ga/