Skip to content

move to hmac instead of ring for hmac calculation #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2022
Merged

move to hmac instead of ring for hmac calculation #662

merged 1 commit into from
Feb 22, 2022

Conversation

bmc-msft
Copy link
Contributor

As #657 identifies, multiple crates depend on ring. This PR replaces the use of ring with the hmac and sha256, as we implicitly use sha256 from the oauth2 crates in core, identity, storage_blobs, and security_keyvault.

cataggar
cataggar approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@cataggar cataggar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the right way to go.

@rylev rylev merged commit 5296a91 into Azure:main Feb 22, 2022
@bmc-msft bmc-msft deleted the use-hmac-instead-of-ring branch February 22, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cataggar cataggar cataggar approved these changes

+1 more reviewer

@rylev rylev rylev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bmc-msft @rylev @cataggar @demoray