Skip to content

Move the TokenCredential trait to azure_core #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2020
Merged

Move the TokenCredential trait to azure_core #56

merged 1 commit into from
Oct 21, 2020

Conversation

rylev
Copy link
Contributor

@rylev rylev commented Oct 21, 2020 •
edited
Loading

Fixes #52

This moves token credential into the core crate.

Unfortunately this requires adding two new dependencies to azure_core:

  • async-trait
  • oauth2

ctaggart
ctaggart approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@ctaggart ctaggart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rylev rylev merged commit 97800d6 into Azure:master Oct 21, 2020
@rylev rylev deleted the tokencredential-in-core branch October 21, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ctaggart ctaggart ctaggart approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move TokenCredential to azure_core
2 participants
@rylev @ctaggart