-
Notifications
You must be signed in to change notification settings - Fork 314
Project Organization Refactoring #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9f4ae97
to
d952b77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only skimmed this. To be honest, given where we are with trying to get this in shape to really get going on new work and how much re-organization this is, I'm fine with taking this as a first stab (though nest under "sdk" if you would) and going from there. I imagine we'll have a few more iterations as we get naming figured out. So this is a great first stab and I say "go for it".
We should probably also reset versions to 1 since we'll want to rename packages anyway to align closer to our track 2 libs, where python and javascript names are probably closer to idiomatic than .NET and Java.
- name: tests | ||
run: cargo test --all | ||
|
||
- name: fmt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have much more experience with AzDO (and AppVeyor) than GH Actions, but is it possible to have this run even if tests
fail so we get more information at once (i.e. some tests failed, but also some formatting is wrong)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... I can look into that. I think it's possible.
Cargo.toml
Outdated
"azure_sdk_storage_table", | ||
"azure_sdk_cosmos", | ||
"azure_sdk_storage_queue" | ||
"auth_aad", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should go under an sdk subfolder, e.g. sdk/auth_aad. This is consistent across our languages.
Fixes #3
This PR does the following:
Open questions:
auth_aad
to justauth
and have AAD functionality behind a feature (so that if we add new auth varieties we can simply add new features?