Skip to content

Conversation

rylev
Copy link
Contributor

@rylev rylev commented Oct 8, 2020

Fixes #3

This PR does the following:

  • Rename the sub-crates' directories removing the azure-sdk prefix
  • Collapse the various storage crates into one gated on features
  • Added GitHub Actions for CI (and removed Travis)
  • Update some of the READMEs and urls to point to this repo and not the old one
  • Update any dependencies that could be updated without breaking things.

Open questions:

  • The storage crate is not ideally structured. I simply moved the previous crates into a single crate with submodules. We might want to rearrange things.
  • The storage crate defaults to all features. This is convenient, but means that by default the project will be slow to build. What's the right trade off here?
  • Should we rename auth_aad to just auth and have AAD functionality behind a feature (so that if we add new auth varieties we can simply add new features?

@rylev rylev requested review from MindFlavor and heaths October 8, 2020 10:25
@rylev rylev force-pushed the organization-refactoring branch from 9f4ae97 to d952b77 Compare October 8, 2020 13:40
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only skimmed this. To be honest, given where we are with trying to get this in shape to really get going on new work and how much re-organization this is, I'm fine with taking this as a first stab (though nest under "sdk" if you would) and going from there. I imagine we'll have a few more iterations as we get naming figured out. So this is a great first stab and I say "go for it".

We should probably also reset versions to 1 since we'll want to rename packages anyway to align closer to our track 2 libs, where python and javascript names are probably closer to idiomatic than .NET and Java.

- name: tests
run: cargo test --all

- name: fmt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have much more experience with AzDO (and AppVeyor) than GH Actions, but is it possible to have this run even if tests fail so we get more information at once (i.e. some tests failed, but also some formatting is wrong)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... I can look into that. I think it's possible.

Cargo.toml Outdated
"azure_sdk_storage_table",
"azure_sdk_cosmos",
"azure_sdk_storage_queue"
"auth_aad",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should go under an sdk subfolder, e.g. sdk/auth_aad. This is consistent across our languages.

@rylev rylev merged commit be89d2d into Azure:master Oct 9, 2020
@rylev rylev deleted the organization-refactoring branch October 9, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rearrange the crates

2 participants