Skip to content

Conversation

maxburke
Copy link
Contributor

@maxburke maxburke commented Feb 9, 2021

No description provided.

@ghost
Copy link

ghost commented Feb 9, 2021

CLA assistant check
All CLA requirements met.

@maxburke
Copy link
Contributor Author

maxburke commented Feb 9, 2021

Fixes #165

Copy link
Contributor

@MindFlavor MindFlavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, thank you!

Can you please fix the blocking issues?

@sophiajt
Copy link

Looks like the build is failing on:

  --> sdk/storage/src/blob/blob/requests/put_block_list_builder.rs:50:36
   |
50 |         access_tier: AccessTier => access_tier,
   |                                    ^^^^^^^^^^^
   |                                    |
   |                                    expected enum `std::option::Option`, found enum `access_tier::AccessTier`
   |                                    help: try using a variant of the expected enum: `blob::_::_serde::__private::Some(access_tier)`
   |
   = note: expected enum `std::option::Option<access_tier::AccessTier>`
              found enum `access_tier::AccessTier`

Were you able to build everything locally? Just guessing from the error above, it seems like it wants a Some(access_tier) instead of access_tier.

@maxburke
Copy link
Contributor Author

Looks like the build is failing on:

  --> sdk/storage/src/blob/blob/requests/put_block_list_builder.rs:50:36
   |
50 |         access_tier: AccessTier => access_tier,
   |                                    ^^^^^^^^^^^
   |                                    |
   |                                    expected enum `std::option::Option`, found enum `access_tier::AccessTier`
   |                                    help: try using a variant of the expected enum: `blob::_::_serde::__private::Some(access_tier)`
   |
   = note: expected enum `std::option::Option<access_tier::AccessTier>`
              found enum `access_tier::AccessTier`

Were you able to build everything locally? Just guessing from the error above, it seems like it wants a Some(access_tier) instead of access_tier.

Ah, my branch is behind. Rebased and rebuilt and it's fine now.

@MindFlavor MindFlavor merged commit dbc7433 into Azure:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants