Skip to content

Cleanup core #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 8, 2021
Merged

Cleanup core #162

merged 12 commits into from
Feb 8, 2021

Conversation

rylev
Copy link
Contributor

@rylev rylev commented Jan 27, 2021

Starts to address #35. This PR does the following:

  • Moves all request options to a separate submodule.
  • Deletes or moves all "XRequired" and "XOption" traits
  • Moves some stuff around

@rylev rylev requested a review from MindFlavor January 27, 2021 15:36
MindFlavor
MindFlavor reviewed Jan 27, 2021
View reviewed changes
@rylev rylev merged commit 606a99e into Azure:master Feb 8, 2021
@rylev rylev deleted the cleanup-core branch February 8, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MindFlavor MindFlavor MindFlavor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rylev @MindFlavor