use expire_on from Azure CLI 2.54.0 if it exists #1534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cataggar
changed the title
cataggar
commented
Jan 2, 2024
demoray
reviewed
Jan 2, 2024
demoray
reviewed
Jan 2, 2024
demoray
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1533. Now that Azure/azure-cli#19700 was released with Azure CLI 2.54.0 in November, the
expires_ontimestamp can be used instead ofexpiresOnthat is a local date. It will be used if present. It will continue to fallback toexpiresOnif theold_azure_clifeature is enabled. I added it to default features. May be in 2025, we can remove it from default features.