Skip to content

Deny missing docs in cosmos #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2021
Merged

Deny missing docs in cosmos #153

merged 1 commit into from
Jan 20, 2021

Conversation

rylev
Copy link
Contributor

@rylev rylev commented Jan 19, 2021

Some missing docs are still permitted but now when adding new items, documentation or an explicit #[allow(missing_docs)] will be required.

@rylev rylev requested a review from MindFlavor January 19, 2021 16:43
@rylev rylev force-pushed the cosmos-deny-missing-docs branch from 0605296 to b8f31c7 Compare January 19, 2021 16:58
MindFlavor
MindFlavor approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@MindFlavor MindFlavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, nice work. It also has the added benefit of constraining better the visibility of some functions (like prepare_request). 👍

@rylev rylev merged commit 02949f4 into Azure:master Jan 20, 2021
@rylev rylev deleted the cosmos-deny-missing-docs branch January 20, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MindFlavor MindFlavor MindFlavor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rylev @MindFlavor