move away from directory listings for finding generated crates #1509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As identified in Azure#1479, we do not currently handle deleted/renamed specifications well. This update addresses this via the following: * Moves to using parsing `cargo_toml` to parse services/Cargo.toml to know what crates already exist * Replaces all uses of `list_crate_names` with using the results of `gen_crates` As a byproduct, this identifies that the previously existing spec that would result in `azure_svc_codesigning` was removed. ref: Azure/azure-rest-api-specs#26635
cataggar
approved these changes
Dec 8, 2023
demoray
deleted the
dont-use-directory-listings-for-identifying-crates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified in #1479, we do not currently handle deleted/renamed specifications well.
This update addresses this via the following:
cargo_tomlto parse services/Cargo.toml to know what crates already existlist_crate_nameswith using the results ofgen_cratesAs a byproduct, this identifies that the previously existing spec that would result in
azure_svc_codesigningwas removed.ref: Azure/azure-rest-api-specs#26635