Expose default tag as feature #1492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, if you want to specify the http client implementation, you
_also_ must specify the package tag which can change regularly during
updates.
This moves to including a feature named `default_tag` which refers to
the specific tag name, as well as renames `no-default-tag` to
`without_tag_import` to do what was previously referred as
`no-default-tag`.
This allows users to have a consistent Cargo.toml entry for the latest
tag and a specified http client such as the following:
`azure_svc_batch = {version="0.17", default-features=false, features=["enable_reqwest", "default_tag"]}`
|
Note, this is important as I am looking to address #1487 by making use of models from the generated crate, where we want to specify the HTTP client but not have to keep the default tag up-to-date. |
cataggar
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if you want to specify the http client implementation, you also must specify the package tag which can change regularly during updates.
This moves to including a feature named
default_tagwhich refers to the specific tag name, as well as renamesno-default-tagtowithout_tag_importto do what was previously referred asno-default-tag.This allows users to have a consistent Cargo.toml entry for the latest tag and a specified http client such as the following:
This PR is broken up into two commits. The first is the change to the generator. The second is the changes after regenerating the crates.