Skip to content

Conversation

krishanjmistry
Copy link
Contributor

@krishanjmistry krishanjmistry commented Dec 1, 2023

Personal opinion: it's quite difficult to navigate through the codegen_[operations/models] files.
The changes made here split codegen_operations.rs into several files.

There was also some duplications DocCommentCode that I noticed - now operations and models use the same

Tested by running azure-autorust. No changes found to any of the autogenerated crates.

Things noticed:

@krishanjmistry krishanjmistry marked this pull request as ready for review December 1, 2023 19:21
@demoray demoray requested a review from cataggar December 1, 2023 23:47
Copy link
Member

@cataggar cataggar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'm okay with splitting it up.

@cataggar cataggar merged commit aa6f234 into Azure:main Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants