Lockdown oauth2 crate version to unblock build #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Since we wanted to update tokio anyway, I went ahead and fixed this in #136 |
|
@rylev The alpha.3 version still need to be locked, otherwise it could be broken in future? |
|
@karataliu you're probably right since it seems oauth2 is not following any kind of semver guarantees in their alpha releases. I'm reopening this PR. Can you push a change to bump to alpha3? |
|
updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #134
version='a' has same semantic of '^a', which will auto pick version with same major version. This won't work for packages on alpha version, which can have breaking change.