Skip to content

add service bus topic support #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2022
Merged

add service bus topic support #1155

merged 1 commit into from
Nov 30, 2022

Conversation

pavelm10
Copy link
Contributor

Implements #1154

@pavelm10 pavelm10 force-pushed the feature/sb-topic branch 2 times, most recently from 5fc4b8c to 222c16b Compare November 22, 2022 16:55
@cataggar cataggar requested a review from danbugs November 29, 2022 00:26
rylev
rylev approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. We need to switch the servicebus crate over to using the pipeline architecture that the other SDKs are using which would help with adding tests.

@bmc-msft bmc-msft linked an issue Nov 30, 2022 that may be closed by this pull request
Add Service Bus Topic Functionality #1154
Closed
@bmc-msft bmc-msft merged commit 8b91537 into Azure:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danbugs danbugs Awaiting requested review from danbugs

1 more reviewer

@rylev rylev rylev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Service Bus Topic Functionality

3 participants

@pavelm10 @rylev @bmc-msft