Skip to content

Conversation

cataggar
Copy link
Member

@heaths
Copy link
Member

heaths commented Sep 27, 2022

I'm not clear on what the intent is, but the Azure guidelines dictate the following values:

  • notStarted
  • running
  • succeeded
  • failed
  • canceled

Technically, that spec still has them as PascalCase, but more recent conversations have us recommending camelCase for enum values. Whatever the case, the public API would be using snake_case anyway, but we should probably handle these values case-insensitively as well as "cancelled" == "canceled" like we do in other languages.

I'll ping @JeffreyRichter and others offline about the casing of these values as we recommended them here, but the case-insensitive text is still correct.

@cataggar
Copy link
Member Author

I used this example to locate the 8 services that are using Cancelled in provisioningState, when they should be using Canceled. This includes the vmware service, which I manage. I still think this example is worth merging. It shows how to loop through the models for analysis.

@cataggar cataggar merged commit de1e066 into Azure:main Sep 28, 2022
@cataggar cataggar deleted the cancelled_analysis branch September 28, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants