Skip to content

Conversation

hanhossain
Copy link
Member

I was trying to use the SDK against the CosmosDB emulator, and it looks like CosmosClientBuilder has a few public methods which aren't usable right now as CloudLocation is not public. This one-liner exports CloudLocation as public to allow those methods to be used.

Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks like CI doesn't pass because the newly public CloudLocation is not properly documented (and we require all public items to be documented). Would you mind trying to document the struct?

@hanhossain hanhossain requested a review from rylev August 31, 2022 17:13
Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rylev rylev merged commit 97b7c12 into Azure:main Sep 1, 2022
@hanhossain hanhossain deleted the public-cloud-location branch September 2, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants