Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key Vault Certificates #6467

Closed
wants to merge 166 commits into from
Closed

Key Vault Certificates #6467

wants to merge 166 commits into from

Conversation

iscai-msft
Copy link
Contributor

No description provided.

samvaity and others added 30 commits July 1, 2019 16:58
@samvaity
working test case
84e325f
@samvaity
adding more impl
3c4baeb
@samvaity
crud working
ec9a925
@samvaity
working until contacts
4f35316
@samvaity
all working
e121e4d
@samvaity
working all
e53155c
@iscai-msft
passes initial tests
45559a2
@iscai-msft
Merge branch 'master' into keyvault-certs
f26938d
@iscai-msft
added some changes after design meeting, crud issuers passes
bb2bf3f
@iscai-msft
added list to crud issuers and passes, merge certs not passing
955da45
@iscai-msft
fixed CeritificatePolicy wrapper class, all tests besides merge certi…
c87f6dd 
…ficates pass
@iscai-msft
hello world sample works
5a6c05a
@iscai-msft
list operations sample passing
3a0d425
@iscai-msft
all sync samples working
7c592f6
@iscai-msft
get_pending_csr test passes
8aa6eb8
@iscai-msft
Merge branch 'keyvault-certs' of github.com:iscai-msft/azure-sdk-for-…
0acec0c 
…python into keyvault-certs
@iscai-msft
switched import certificates parameter to bytes
6bfa74e
@iscai-msft
modified wrapped models, added docstrings
2485f02
@iscai-msft
uncommented tests
9c6fd42
@iscai-msft
added readme for certificates
c5825ad
@iscai-msft
deleted pip and lock file
d8e59e8
@iscai-msft
deleted copied secret aio implementation
aaf9220
@iscai-msft
pulled origin master key recordings
86746f9
@iscai-msft
Merge branch 'master' of github.com:Azure/azure-sdk-for-python into k…
835ad10 
…eyvault-certs
@iscai-msft
added _shared folder
043de50
@iscai-msft
added test recordings for secrets and keys for CI
40528c5
@iscai-msft
passes hello word sample test
3f57c36
@iscai-msft
adding samples tests, waiting to hear from keyvault team about questions
d73cf66
@iscai-msft
changed default enabled value to True
6119001
@iscai-msft
implemented async client
e6e1aa3
chlowell
chlowell reviewed Aug 29, 2019
View reviewed changes
sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/__init__.py Outdated Show resolved Hide resolved
sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/aio/__init__.py Outdated Show resolved Hide resolved
sdk/keyvault/azure-keyvault-certificates/conftest.py Outdated Show resolved Hide resolved
sdk/keyvault/azure-keyvault-certificates/setup.py Outdated Show resolved Hide resolved
sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/client.py Outdated Show resolved Hide resolved
sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/client.py Outdated Show resolved Hide resolved
sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/client.py Outdated Show resolved Hide resolved
sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/client.py Outdated Show resolved Hide resolved
sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/models.py Outdated Show resolved Hide resolved
sdk/keyvault/azure-keyvault-certificates/samples/list_operations_async.py Outdated Show resolved Hide resolved
@iscai-msft
implemented lro for create certificate, all tests passing
9fb3745
@iscai-msft
implemented Charles' suggestions
c2d584e
@iscai-msft
implemented Charles' comments
c6ae595
@iscai-msft
moved sans to kwargs, added comments to models
b7d3d24
@iscai-msft
fixed links in samples
c18a9a1
@iscai-msft
Merge remote-tracking branch 'origin/master' into certs-async
80d189d
@iscai-msft
Merge branch 'master' of github.com:Azure/azure-sdk-for-python into c…
eb7922c 
…erts-async
@iscai-msft
fixed typing error, awaited all async pollers
b2fb410
@iscai-msft
updated lowerbound for azure core version
a681e89
@iscai-msft
fixed linting errors
901dcae
@iscai-msft
updated readme
c820f00
@iscai-msft
parsing out certificate id in poller
98ff072
@iscai-msft
added model imports in aio init
5e4d99e
@iscai-msft
fixed init files to just use models passed to methods
6b4a33a
@iscai-msft
fixed enum conversion and import statements
84ced76
@iscai-msft
split get_certificate into one with version and one with policy
1840071
@iscai-msft
fixed docstrings, added ResourceNotFoundError and ResourceExistError …
390e692 
…to error map
@iscai-msft
fixed linting error
1e9bf73
@iscai-msft
reordered logic in conftest for RUN_IDENTIFIER
960a9b4
@iscai-msft
reverted SecretContentType types and get_pending_csr
69808a4
@iscai-msft
Copy link
Contributor Author

I've opened a new PR with the commit history squashed because there are so many commits here: #7076

@iscai-msft iscai-msft closed this Sep 5, 2019
@iscai-msft iscai-msft deleted the certs-async branch September 5, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlowell chlowell chlowell left review comments

@johanste johanste johanste left review comments

@schaabs schaabs Awaiting requested review from schaabs

@bryevdv bryevdv Awaiting requested review from bryevdv

@xiangyan99 xiangyan99 Awaiting requested review from xiangyan99

@zikalino zikalino Awaiting requested review from zikalino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iscai-msft @adxsdk6 @chlowell @johanste @samvaity