Enable recordings for Agent function tool, and switch over to new recording decorators #44292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dargilco
requested review from
glharper,
howieleung,
kingernupur,
nick863,
trangevi and
trrwilson
as code owners
dargilco
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables test recording capabilities for Agent function tool tests and consolidates test infrastructure by removing temporary custom decorators in favor of standardized ones from the devtools_testutils library. The changes improve test maintainability and add comprehensive async test coverage for Agent function tools.
Key changes:
- Adds async versions of Agent function tool tests with full multi-turn conversation support
- Migrates all OpenAI client tests from custom recording decorators to standardized devtools_testutils decorators
- Removes over 200 lines of temporary decorator implementations from test_base.py
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/ai/azure-ai-projects/tests/test_base.py | Removes unused imports and deprecated custom recording decorators (recorded_by_proxy_httpx, recorded_by_proxy_async_httpx) |
| sdk/ai/azure-ai-projects/tests/agents/tools/test_agent_function_tool_async.py | Adds comprehensive async tests for Agent function tools with recording support |
| sdk/ai/azure-ai-projects/tests/agents/tools/test_agent_function_tool.py | Migrates to standardized recording decorators and replaces manual assertions with _validate_agent_version helper |
| sdk/ai/azure-ai-projects/tests/agents/test_conversation_items_crud_async.py | Updates to use standardized recorded_by_proxy_async decorator |
| sdk/ai/azure-ai-projects/tests/agents/test_conversation_items_crud.py | Updates to use standardized recorded_by_proxy decorator and removes outdated TODO comment |
| sdk/ai/azure-ai-projects/tests/agents/test_conversation_crud_async.py | Updates decorator and adds helpful test execution comment |
| sdk/ai/azure-ai-projects/tests/agents/test_conversation_crud.py | Updates decorator and adds helpful test execution comment |
| sdk/ai/azure-ai-projects/tests/agents/telemetry/test_responses_instrumentor_metrics.py | Migrates all tests to use standardized recording decorator |
| sdk/ai/azure-ai-projects/tests/agents/telemetry/test_responses_instrumentor_async.py | Migrates all async tests to use standardized recording decorator |
| sdk/ai/azure-ai-projects/tests/agents/telemetry/test_responses_instrumentor.py | Migrates all tests to use standardized recording decorator |
howieleung
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.