Skip to content

Conversation

@YoYoJa
Copy link
Contributor

@YoYoJa YoYoJa commented Nov 10, 2025

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copilot AI review requested due to automatic review settings November 10, 2025 02:17
@YoYoJa YoYoJa requested a review from a team as a code owner November 10, 2025 02:17
@github-actions github-actions bot added the Evaluation Issues related to the client library for Azure AI Evaluation label Nov 10, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the _convert_results_to_aoai_evaluation_results function to support input keys without the "inputs." prefix. Previously, only keys prefixed with "inputs." or "outputs." were processed; now non-prefixed keys are also included in the evaluation results.

Key changes:

  • Modified the key processing logic to handle non-prefixed input keys
  • Updated test data to include examples with non-prefixed keys (e.g., "query")
  • Updated expected test outputs to reflect the new behavior

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluate/_evaluate.py Changed from elif to else to process all non-output keys, with conditional prefix stripping for "inputs." prefixed keys
sdk/evaluation/azure-ai-evaluation/tests/unittests/data/evaluation_util_convert_old_output_test.jsonl Added "query" as a top-level key in test data to demonstrate support for non-prefixed input keys
sdk/evaluation/azure-ai-evaluation/tests/unittests/data/evaluation_util_convert_expected_output.json Updated expected output to include the new "query" field in rows and datasource_item objects

@YoYoJa YoYoJa enabled auto-merge (squash) November 10, 2025 03:51
@w-javed
Copy link
Contributor

w-javed commented Nov 10, 2025

/check-enforcer override

@YoYoJa YoYoJa merged commit d35f12e into main Nov 10, 2025
15 of 20 checks passed
@YoYoJa YoYoJa deleted the jessli/UpdateMappings branch November 10, 2025 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Evaluation Issues related to the client library for Azure AI Evaluation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants