Skip to content

Conversation

@kdestin
Copy link
Member

@kdestin kdestin commented Oct 9, 2025

Description

This pull request marks GroundednessEvaluator.has_context as "private".

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@kdestin kdestin requested a review from a team as a code owner October 9, 2025 21:36
Copilot AI review requested due to automatic review settings October 9, 2025 21:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request marks the has_context method in the GroundednessEvaluator class as private by renaming it to _has_context. This is a code cleanup change that improves encapsulation by hiding an internal utility method from the public API.

  • Renames has_context method to _has_context to make it private
  • Updates the method call reference to use the new private method name

@kdestin kdestin enabled auto-merge (squash) October 9, 2025 21:37
@github-actions github-actions bot added the Evaluation Issues related to the client library for Azure AI Evaluation label Oct 9, 2025
@github-actions
Copy link

github-actions bot commented Oct 9, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

azure-ai-evaluation

@kdestin kdestin merged commit 79f9a4a into Azure:main Oct 9, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Evaluation Issues related to the client library for Azure AI Evaluation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants