Sync eng/common directory with azure-sdk-tools for PR 12416 #43302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes the eng/common directory with azure-sdk-tools PR 12416, updating the API change detection script to improve parameter handling and fix a typo. The changes modernize how package information is passed to functions while maintaining backward compatibility.
Key Changes
- Refactored
Should-Process-Packagefunction to accept apackageInfoobject instead of separate parameters - Added dynamic function parameter detection to support both new and legacy calling conventions
- Fixed a typo in a log message
raych1
approved these changes
Oct 9, 2025
azure-sdk
deleted the
sync-eng/common-users/raych1/update-detect-api-changes-template-12416
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12416 See eng/common workflow