Howie/re emit #43191
Open
Howie/re emit #43191
+172
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howieleung
requested review from
trangevi,
glharper and
nick863
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure AI Agents SDK by regenerating it from an updated API specification, enhancing documentation for Bing search configuration parameters, and cleaning up pylint directives.
- Updated TypeSpec commit reference to incorporate API specification changes
- Enhanced documentation for Bing search configuration parameters with detailed descriptions
- Removed unnecessary pylint disable directives from generated files
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/ai/azure-ai-agents/tsp-location.yaml | Updated commit hash to reference newer API specification |
| sdk/ai/azure-ai-agents/tests/test_ai_instrumentor_base.py | Added pylint directive for line length and suppression |
| sdk/ai/azure-ai-agents/samples/agents_response_formats/sample_agents_json_schema_response_format.py | Added pylint directive for line length and suppression |
| sdk/ai/azure-ai-agents/azure/ai/agents/operations/_operations.py | Removed pylint disable directive for too-many-lines |
| sdk/ai/azure-ai-agents/azure/ai/agents/models/_models.py | Removed pylint directives and enhanced documentation for Bing configuration classes |
| sdk/ai/azure-ai-agents/azure/ai/agents/aio/operations/_operations.py | Removed pylint disable directives |
| sdk/ai/azure-ai-agents/azure/ai/agents/_utils/model_base.py | Removed pylint disable directives |
| sdk/ai/azure-ai-agents/CHANGELOG.md | Updated release date for version 1.2.0b5 |
Comment on lines
993
to
994
| `YYYY-MM-DD..YYYY-MM-DD`. For example, `freshness=2019-02-01..2019-05-30. To limit the results | ||
| to a single date, set this parameter to a specific date. For example, freshness=2019-02-04`. |
There was a problem hiding this comment.
Missing closing backtick after the date range example. Should be freshness=2019-02-01..2019-05-30.
Suggested change
| `YYYY-MM-DD..YYYY-MM-DD`. For example, `freshness=2019-02-01..2019-05-30. To limit the results | |
| to a single date, set this parameter to a specific date. For example, freshness=2019-02-04`. | |
| `YYYY-MM-DD..YYYY-MM-DD`. For example, `freshness=2019-02-01..2019-05-30`. To limit the results | |
| to a single date, set this parameter to a specific date. For example, `freshness=2019-02-04`. |
Copilot uses AI. Check for mistakes.
| * Week: Return webpages that Bing discovered within the last 7 days. | ||
| * Month: Return webpages that Bing discovered within the last 30 days. To get articles | ||
| discovered by Bing during a specific timeframe, specify a date range in the form: | ||
| `YYYY-MM-DD..YYYY-MM-DD`. For example, `freshness=2019-02-01..2019-05-30. To limit the results |
There was a problem hiding this comment.
Missing closing backtick after the date range example. Should be freshness=2019-02-01..2019-05-30.
Suggested change
| `YYYY-MM-DD..YYYY-MM-DD`. For example, `freshness=2019-02-01..2019-05-30. To limit the results | |
| `YYYY-MM-DD..YYYY-MM-DD`. For example, `freshness=2019-02-01..2019-05-30`. To limit the results |
Copilot uses AI. Check for mistakes.
howieleung
force-pushed
the
howie/re-emit
branch
from
8c15d45 to
26695d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines