Skip to content

Conversation

ahibrahimm
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Evaluation Issues related to the client library for Azure AI Evaluation labels Sep 28, 2025
Copy link

Thank you for your contribution @ahibrahimm! We will review the pull request and get back to you soon.

@ahibrahimm ahibrahimm marked this pull request as ready for review September 28, 2025 07:17
@ahibrahimm ahibrahimm requested a review from a team as a code owner September 28, 2025 07:17
@Copilot Copilot AI review requested due to automatic review settings September 28, 2025 07:17
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds explicit None default value handling to the groundedness evaluator's parameter extraction logic. The change ensures consistent null-safe parameter handling in the evaluator's keyword argument conversion process.

  • Adds explicit None default to the query parameter extraction in _convert_kwargs_to_eval_input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Evaluation Issues related to the client library for Azure AI Evaluation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant