Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR] securityinsights/resource-manager #4268

Closed

Conversation

AutorestCI
Copy link
Contributor

Created to accumulate context: securityinsights/resource-manager

… Scheduled Alert Rules (#4229)

* Generated from b63cbf7f7de110a9611e2c0d1f0b077920963104

Merge branch 'master' of https://github.com/nirgfani/azure-rest-api-specs

* Packaging update of azure-mgmt-securityinsight

* Generated from 1d1029b373596e1dfe05b66fce115d5fd4b5ea57

Fixing comments from PR-

* Changing durations to fit standards
* Changing operators to fit other RPs
* Align naming to scheduledAlertRules
* Adding 200 response to DeleteScheduledAlertRule

* Generated from 573869de582350c81ae8c39877c2a170ac85cbfd

Adding kind to AlertRule and making Scheduled as a specific kind

* Generated from 27d8376898b34d8f7a3c1a0f31ba53ca217afa57

Fix some errors

* Generated from 0f74576d2fa0ae3526c5f42c39de849ddce62396

Trying to solve the model validator issues
@AutorestCI
Copy link
Contributor Author

AutorestCI commented Jan 30, 2019

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-securityinsight

You can install the package azure-mgmt-securityinsight of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_securityinsights/resource-manager#egg=azure-mgmt-securityinsight&subdirectory=azure-mgmt-securityinsight"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_securityinsights/resource-manager#egg=azure-mgmt-securityinsight&subdirectory=azure-mgmt-securityinsight"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_securityinsights/resource-manager
  • pip install -e ./azure-mgmt-securityinsight

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_securityinsights/resource-manager
  • pip wheel --no-deps ./azure-mgmt-securityinsight

Direct download

Your files can be directly downloaded here:

#4279)

* Generated from 1a6ebaa4e0f6627020df1cb8706b481ba4aef7c6

Try to fix some checks issues

* Generated from 852097272ac674f1b2931aa299767468407eed51

Try to fix issues once again

* Generated from c69c6aa9b511b58e14d2711c23c607476f4da35b

Fixing typos
@codecov-io
Copy link

codecov-io commented Feb 5, 2019

Codecov Report

Merging #4268 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4268      +/-   ##
==========================================
+ Coverage   53.76%   53.81%   +0.05%     
==========================================
  Files        9800    10282     +482     
  Lines      209955   218554    +8599     
==========================================
+ Hits       112879   117619    +4740     
- Misses      97076   100935    +3859
Impacted Files Coverage Δ
...y/models/self_hosted_integration_runtime_status.py 56.09% <0%> (-43.91%) ⬇️
...tafactory/azure/mgmt/datafactory/models/dataset.py 61.53% <0%> (-38.47%) ⬇️
...azure/mgmt/datafactory/models/pipeline_resource.py 62.5% <0%> (-37.5%) ⬇️
...datafactory/models/azure_storage_linked_service.py 63.15% <0%> (-36.85%) ⬇️
...tafactory/azure/mgmt/datafactory/models/factory.py 66.66% <0%> (-33.34%) ⬇️
...zure/mgmt/datafactory/models/azure_blob_dataset.py 68.18% <0%> (-31.82%) ⬇️
...afactory/azure/mgmt/datafactory/models/activity.py 70% <0%> (-30%) ⬇️
...y/azure/mgmt/datafactory/models/lookup_activity.py 70.58% <0%> (-29.42%) ⬇️
...afactory/azure/mgmt/datafactory/models/resource.py 72.22% <0%> (-27.78%) ⬇️
...mgmt/datafactory/models/pipeline_run_invoked_by.py 73.33% <0%> (-26.67%) ⬇️
... and 784 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d31aefc...9a6449e. Read the comment docs.

)

* Generated from 36b0f2d1546045298331a242d98069c0e6af3c0c

fixed the CloseReason x-ms-enum name

* Generated from ceed8746e2edeaf5c211e6490bc89c52712b0f34

Fixing comments from PR

* Generated from 04b7d638ff87ca0ade886655d1965ba363ce0dc7

Change in dataConnectors from contextId to the relevant ID

* Generated from 8af921b0a21d3980f99401044c4f84d4467dc5a8

Fixing the code according to discussion.

Actions will be only nested resource at the moment, so ruleId is not needed currently.
Patterns will be removed so Guid will not be mandatory as parameter.
ruleName will be cahanged to displayName in AlertRules

* Generated from 455c9b456a849ede16da071ad6da7bb3ed0bfd4e

Fixing validation error

* Generated from 22bf30282758b6cd3f4ebb2bf535946a1851bec0

updating the operationIds to be more precise
typo: securityinsights/resource-manager/Microsoft.SecurityInsights

- stting -> setting
- etnties -> entities
- NETBIOS -> NetBIOS
- operartion -> operating
- concesnt -> consent
…oint to SecurityInsights RP swagger spec (#4742)

* Generated from f20f1d94a584bf55c225139c0991138b1c90420f

Add cases aggregation endpoint to SecurityInsights RP swagger spec

* Packaging update of azure-mgmt-securityinsight

* Generated from 2e84b343d46947d2cc6d9f79a64ced02e82027c6

Fix pathParam and add Tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants