adding warning if pat detects in git url while creation of job #40337
+107
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayesh-tanna
requested review from
paulshealy1,
achauhan-scc and
kingernupur
as code owners
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces functionality to detect a PAT token in Git repository URLs during job creation and removes sensitive Git-related properties if a PAT token is detected.
- Added a helper function (has_pat_token) to detect PAT tokens in Git URLs.
- Updated job operations to remove Git properties when a PAT token is present.
- Added corresponding unit tests and updated the changelog to reflect these changes.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/job_common/unittests/test_job_ops_helper.py | Added unit tests for the new has_pat_token function. |
| azure/ai/ml/operations/_job_ops_helper.py | Added the has_pat_token helper function to detect PAT tokens in URLs. |
| azure/ai/ml/operations/_job_operations.py | Integrated has_pat_token to remove Git properties if a PAT token is detected. |
| CHANGELOG.md | Documented the removal of Git-related properties for PAT-containing URLs. |
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
achauhan-scc
approved these changes
Apr 3, 2025
kingernupur
approved these changes
Apr 3, 2025
kshitij-microsoft
approved these changes
Apr 3, 2025
nik1097
pushed a commit
to nik1097/azure-sdk-for-python
that referenced
this pull request
Apr 5, 2025
…#40337) * adding warning if pat detects in git url while creation of job * adding test cases * applying black formatter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines