-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoRelease] t2-networkcloud-2025-04-02-99243(can only be merged by SDK owner) #40334
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the default API version from "2024-07-01" to "2024-10-01-preview" across all operations and configuration files while introducing a series of new models and enums to support enhanced logging, secret archival, and vulnerability scanning functionality. It also bumps the package version and includes minor documentation improvements.
Reviewed Changes
Copilot reviewed 208 out of 209 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
_kubernetes_cluster_features_operations.py | Updated API version default for Kubernetes cluster feature operations. |
_consoles_operations.py, _clusters_operations.py, _cluster_managers_operations.py, _cloud_services_networks_operations.py, _bmc_key_sets_operations.py, _bare_metal_machines_operations.py, _bare_metal_machine_key_sets_operations.py, _agent_pools_operations.py | Consistently updated the default API version across various operations modules. |
_network_cloud_mgmt_client_enums.py | Added new enum members for OS disk and storage appliance status. |
_models_py3.py | Introduced new models (AnalyticsOutputSettings, SecretArchiveSettings, VulnerabilityScanningSettings, etc.) and updated existing model documentation. |
init.py (models) | Updated initialization to export the new models and enums. |
aio/_network_cloud_mgmt_client.py, aio/_configuration.py | Updated API version defaults in asynchronous client configurations. |
_version.py, _network_cloud_mgmt_client.py, _configuration.py | Bumped version and updated API version defaults in synchronous files. |
README.md | Fixed a documentation typo regarding environment variable configuration. |
CHANGELOG.md | Added changelog entries for the new beta release detailing new features and model updates. |
Files not reviewed (1)
- sdk/networkcloud/azure-mgmt-networkcloud/_meta.json: Language not supported
Comments suppressed due to low confidence (6)
sdk/networkcloud/azure-mgmt-networkcloud/azure/mgmt/networkcloud/operations/_kubernetes_cluster_features_operations.py:52
- Verify that the new API version '2024-10-01-preview' is fully supported by all endpoints and update corresponding tests to validate behavior.
api_version: str = kwargs.pop("api_version", _params.pop("api-version", "2024-10-01-preview"))
sdk/networkcloud/azure-mgmt-networkcloud/azure/mgmt/networkcloud/models/_models_py3.py:2413
- [nitpick] Confirm that the new 'analytics_output_settings' property documentation and its use (in conjunction with the deprecated 'analytics_workspace_id') aligns with the design guidelines.
:ivar analytics_output_settings: The settings for the log analytics workspace used for output of logs from this cluster.
sdk/networkcloud/azure-mgmt-networkcloud/CHANGELOG.md:3
- [nitpick] Ensure the release date and version number match the intended beta release details before merging.
## 2.1.0b1 (2025-04-21)
sdk/networkcloud/azure-mgmt-networkcloud/README.md:27
- [nitpick] The wording has been clarified; please ensure similar corrections are applied consistently throughout the documentation.
By default, [Azure Active Directory](https://aka.ms/awps/aad) token authentication depends on correct configuration of the following environment variables.
sdk/networkcloud/azure-mgmt-networkcloud/azure/mgmt/networkcloud/aio/_configuration.py:36
- [nitpick] Ensure that asynchronous unit tests cover scenarios where the API version is overridden and that the new default is applied correctly.
api_version: str = kwargs.pop("api_version", "2024-10-01-preview")
sdk/networkcloud/azure-mgmt-networkcloud/azure/mgmt/networkcloud/_configuration.py:36
- [nitpick] Update tests to validate that the configuration correctly sets the new default API version '2024-10-01-preview' in production scenarios.
api_version: str = kwargs.pop("api_version", "2024-10-01-preview")
https://github.com/Azure/sdk-release-request/issues/5985
Recording test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=6093