Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoRelease] t2-containerservicefleet-2025-04-02-13338(can only be merged by SDK owner) #40333

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

azure-sdk
Copy link
Collaborator

https://github.com/Azure/sdk-release-request/issues/5987
Recording test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=982
BuildTargetingString
azure-mgmt-containerservicefleet
Skip.CreateApiReview

@Copilot Copilot bot review requested due to automatic review settings April 2, 2025 02:45
@azure-sdk
Copy link
Collaborator Author

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR releases version 3.1.0 of the SDK and introduces new auto upgrade related models, enums, and operation groups while updating API version defaults and minor documentation issues. Key changes include:

  • Addition of new auto upgrade models and enums (e.g. AutoUpgradeLastTriggerStatus, AutoUpgradeProfile, UpgradeChannel) and the new operation groups auto_upgrade_profiles and auto_upgrade_profile_operations.
  • Updates to type annotations and configuration defaults (e.g. API version changed from 2024-04-01 to 2025-03-01) along with version bump and README/CHANGELOG updates.
  • Minor code and pylint directive adjustments in various operations and serialization modules.

Reviewed Changes

Copilot reviewed 103 out of 104 changed files in this pull request and generated no comments.

Show a summary per file
File Description
models/_container_service_fleet_mgmt_client_enums.py Adds new enums and updated the NodeImageSelectionType with a new member CUSTOM.
models/init.py Updates all to include new auto upgrade models and enums.
aio/operations/* Removes some redundant pylint disables and updates error_map type annotations uniformly.
_container_service_fleet_mgmt_client.py (sync & async) Introduces new operation groups for auto upgrade profiles and updates client docstrings.
_configuration.py Updates API version defaults and client configuration documentation.
_version.py, README.md, CHANGELOG.md Bumps version to 3.1.0 and improves documentation consistency.
_serialization.py Enhances type hints, error messages, and minor formatting improvements.
Files not reviewed (1)
  • sdk/containerservice/azure-mgmt-containerservicefleet/_meta.json: Language not supported
Comments suppressed due to low confidence (2)

sdk/containerservice/azure-mgmt-containerservicefleet/azure/mgmt/containerservicefleet/aio/operations/_auto_upgrade_profile_operations_operations.py:40

  • [nitpick] The class name 'AutoUpgradeProfileOperationsOperations' is repetitive and may reduce clarity. Consider renaming it to 'AutoUpgradeProfileOperations' if it does not conflict with existing names.
class AutoUpgradeProfileOperationsOperations:

sdk/containerservice/azure-mgmt-containerservicefleet/azure/mgmt/containerservicefleet/aio/operations/_update_runs_operations.py:94

  • [nitpick] The explicit generic type for 'error_map' was removed; reinstating the type parameters (e.g., MutableMapping[int, Type[HttpResponseError]]) could improve type clarity and safety.
error_map: MutableMapping = {

@@ -1,5 +1,32 @@
# Release History

## 3.1.0 (2025-04-02)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frantran please update the date to latest when you decide to merge and release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants