[AutoRelease] t2-search-2025-04-02-90559(can only be merged by SDK owner) #40332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an upgrade functionality for the Azure AI Search service, including synchronous and asynchronous operations. Key changes include:
- Adding new test cases (both sync and async) for the begin_upgrade operation.
- Implementing build_upgrade_request, _upgrade_initial, and begin_upgrade in the core operations.
- Removing deprecated ServiceOperations import and updating sample code, README, and CHANGELOG accordingly.
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/search/azure-mgmt-search/generated_tests/test_search_management_services_operations_async.py | Added async test for begin_upgrade |
| sdk/search/azure-mgmt-search/generated_tests/test_search_management_services_operations.py | Added sync test for begin_upgrade |
| sdk/search/azure-mgmt-search/generated_samples/upgrade_search_service_to_latest_version.py | Updated sample to use client.services.begin_upgrade |
| sdk/search/azure-mgmt-search/azure/mgmt/search/operations/_services_operations.py | Added upgrade request and operation implementations |
| sdk/search/azure-mgmt-search/azure/mgmt/search/operations/_service_operations.py | Removed deprecated ServiceOperations |
| sdk/search/azure-mgmt-search/azure/mgmt/search/init.py | Updated init to remove ServiceOperations export |
| sdk/search/azure-mgmt-search/azure/mgmt/search/aio/operations/_services_operations.py | Added async upgrade request and operation implementations |
| sdk/search/azure-mgmt-search/azure/mgmt/search/aio/operations/_service_operations.py | Removed deprecated async ServiceOperations |
| sdk/search/azure-mgmt-search/azure/mgmt/search/aio/operations/init.py | Updated init to remove ServiceOperations export |
| sdk/search/azure-mgmt-search/azure/mgmt/search/aio/_search_management_client.py | Removed service attribute initialization |
| sdk/search/azure-mgmt-search/azure/mgmt/search/_search_management_client.py | Removed service attribute initialization |
| sdk/search/azure-mgmt-search/README.md | Corrected grammar in authentication section |
| sdk/search/azure-mgmt-search/CHANGELOG.md | Documented new upgrade features and models |
Files not reviewed (1)
- sdk/search/azure-mgmt-search/_meta.json: Language not supported
Comments suppressed due to low confidence (2)
sdk/search/azure-mgmt-search/generated_tests/test_search_management_services_operations_async.py:255
- [nitpick] Consider using a more descriptive placeholder for search_service_name instead of the literal "str" to improve clarity in the test.
search_service_name="str",
sdk/search/azure-mgmt-search/generated_tests/test_search_management_services_operations.py:251
- [nitpick] Consider using a more descriptive placeholder for search_service_name instead of the literal "str" to improve clarity in the test.
search_service_name="str",
ChenxiJiang333
approved these changes
Apr 2, 2025
msyyc
approved these changes
Apr 2, 2025
weirongw23-msft
pushed a commit
to weirongw23-msft/azure-sdk-for-python
that referenced
this pull request
Apr 4, 2025
…ner) (Azure#40332) * code and test * Update changelog for 9.2.0b3 release date * update testcases --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Azure/sdk-release-request/issues/5820
Recording test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1027
BuildTargetingString
azure-mgmt-search
Skip.CreateApiReview