Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit for feature flag support. #40324

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Initial commit for feature flag support. #40324

wants to merge 5 commits into from

Conversation

albertofori
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the App Configuration Azure.ApplicationModel.Configuration label Apr 1, 2025
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-appconfiguration

rossgrambo
rossgrambo reviewed Apr 1, 2025
View reviewed changes
sdk/appconfiguration/azure-appconfiguration/azure/appconfiguration/__init__.py Outdated
GroupAllocation,
Conditions,
Variant,
Telemetry
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should be exposed as "FeatureFlagTelemetry" or something more specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossgrambo rossgrambo rossgrambo left review comments

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
App Configuration Azure.ApplicationModel.Configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albertofori @azure-sdk @rossgrambo